Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug options to CompareWarpAssemble #157

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Conversation

yalsayyad
Copy link
Contributor

that save debug images, including the count image
and the new masks with the additional CLIPPED plane.

<dd> If True then save the Epoch Count Image as a fits file in the `figpath`
<dt> `saveAltMask`
<dd> If True then save the new masks with CLIPPED planes as fits files to the `figpath`
<dt> `figpath`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figPath?

patchId = tempExpRefList[0].dataId
coaddKeys = tempExpRefList[0].getButler().getKeys(self.getCoaddDatasetName(self.warpType))
keyList = sorted(coaddKeys.keys(), reverse=True)
filename = 'epochCountIm-%s.fits' % ('-'.join([str(patchId[k]) for k in keyList]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -1735,6 +1770,10 @@ def computeAltMaskList(self, tempExpRefList, maskSpanSets):
for noDataRegion in noData:
noDataRegion.clippedTo(mask.getBBox()).setMask(mask, 2**noDataValue)
altMaskList.append(mask)
if lsstDebug.Info(__name__).saveAltMask:
filename = 'altMask-%s.fits' % ('-'.join([str(v) for v in warpRef.dataId.values()]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar approach as above, but won't produce the same suffix. Suggest you consolidate the code to produce the suffix, and then they'll match.

@yalsayyad yalsayyad force-pushed the tickets/DM-12101 branch 3 times, most recently from fd9051c to 33c8c38 Compare November 5, 2017 03:21
that save debug images, including the count image
and the new masks with the additional CLIPPED plane.
@yalsayyad yalsayyad merged commit a13132c into master Nov 6, 2017
@ktlim ktlim deleted the tickets/DM-12101 branch August 25, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants