DM-12450: use --reuse-outputs-from instead of doOverwrite options #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
approved these changes
Nov 7, 2017
| This task has no special keyword arguments. | ||
| This task has one special keyword argument: passing reuse=True will cause | ||
| the task to skip the creation of warps that are already present in input | ||
| or output the repositories. |
There was a problem hiding this comment.
Later you changed to datasetExists(..., write=True) so it will only search the output repos?
There was a problem hiding this comment.
Good point; I'll amend that commit to update the comment as well.
TallJimbo
force-pushed
the
tickets/DM-12450
branch
from
603672a
to
2d69a84
Compare
Accepting *args makes it nearly impossible to safely add non-forwarding arguments.
Because we haven't added a new command-line option to set the ctor argument, it's now impossible to achieve set reuse=True from the command-line when running makeCoaddTempExp directly. But it will be possible from coaddDriver.py, and we expect that to be used instead whenever the user might want reuse=True.
TallJimbo
force-pushed
the
tickets/DM-12450
branch
from
2d69a84
to
9146ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that
makeCoaddTempExpis the only CmdLineTask in this package that actually had an overwrite/clobber option prior to these changes (the rest are all in pipe_drivers), and that's why it's getting special treatment. While it might be cleanest to have all of these options handled at the same level, I don't want to restructure the code to achieve that now.