DM-9953: Pixels rejected from coaddition and CCD are not masked on coadds #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Nov 20, 2017
The presence of background matching confuses the code, and it doesn't belong here because it doesn't work on pointed observations. Its removal was approved in RFC-137.
The EDGE pixels from the individual CCDs have printed through into the coadd, but EDGE means "we couldn't search for sources in this area because we couldn't convolve by the PSF near the edge of the image", so this mask plane needs to be converted to something else if we want to keep them. We do want to be able to identify pixels near the edge of the detector because they will have an inexact CoaddPsf. We rename EDGE pixels as SENSOR_EDGE.
Masking of clipped pixels is now done in afw.math.statisticsStack, so the workaround can be removed.
If any of the input images isn't represented in the coadd (due to clipped pixels or chip gaps), the `CoaddPsf` will be inexact. Flag these pixels. Using a mask plane for this allows us to keep SENSOR_EDGE and CLIPPED separate (in case the distinction is important) while providing a convenient shorthand with a clear name that covers both.
We want to know when sources are on pixels that satisfy any of these.
PaulPrice
force-pushed
the
tickets/DM-9953
branch
from
010bb10
to
476acb6
Compare
We measure the variance for forcedPhotCoadd, so might help to have it here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.