Review for DM-3651, pipe_tasks - bookkeeping improvements to makeDiscreteSkyMap #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @param args Arguments for Task.run() | ||
|
|
||
| @return: | ||
| - None if doReturnResults false |
There was a problem hiding this comment.
Maybe say "self.doReturnResults"; took me a moment to remember where that setting comes from.
There was a problem hiding this comment.
OK. I don't think "self" helps as much as talking about the constructor argument, but self is easy, short and precise (whereas one could override the constructor...)
MakeDiscreteSkyMapRunner.__call__ had a similar error that TaskRunner had: it could crash if doReturnResults was True and the task failed. I fixed that, improved the documentation for __call__ and changed it to return a Struct like TaskRunner.
The code that MakeDiscreteSkyMapTask used to save metadata was incorrect. This was in MakeDiscreteSkyMapRunner.__call__. Fixed by calling task.writeMetadata(dataRef) for each dataRef instead of task.writeMetadata(butler).
The metadata is not interesting, so don't save it. I disabled it using the standard technique of having MakeDiscreteSkyMap._getMetadataName() return None. I left the code in the task runner that saves it, because that task runner is more generally useful and might be wanted for tasks that do save metadata.
MakeDiscreteSkyMapTask was disabling saving of config by overriding a method in its task runner, making the task runner less generally useful and obscuring the fact that the task did not save its config. I removed the override in the task runner and replaced it with the standard means of disabling config saving: by having the task's _getConfigName method return None.
r-owen
force-pushed
the
tickets/DM-3651
branch
from
af962e6
to
e1c0bf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.