DM-13243: PhotoCalTask must only match with DirectMatchTask #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhotoCalTask uses a matcher API specific to DirectMatchTask, and the other stack astrometric matchers are not suitable for this subtask. To prevent confusion between these different types of matchers, this removes the ability to retarget the PhotoCal matcher.
Since PhotoCalTask passes a refObjLoader directly to DirectMatchTask, the DirecMatch's refObjLoader config settings do nothing. Switching to DirectMatchConfigWithoutLoader eliminates these settings.
ctslater
force-pushed
the
tickets/DM-13243
branch
from
3b0ea0c
to
6c5987b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the possibility of retargeting matching to an incompatible matcher.