Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-13517: fixes for scaleVariance #192

Merged
merged 3 commits into from Apr 11, 2018
Merged

DM-13517: fixes for scaleVariance #192

merged 3 commits into from Apr 11, 2018

Conversation

PaulPrice
Copy link
Contributor

No description provided.

If the rescaling factor is NAN, *bad* things can happen...
Imaginary universes come crashing down on you when the variance is negative.
maskVal wasn't defined.
Copy link
Contributor

@hsinfang hsinfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to the commit messages :D

@PaulPrice PaulPrice merged commit 0f5851b into master Apr 11, 2018
@ktlim ktlim deleted the tickets/DM-13517 branch August 25, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants