DM-13790: Remove all use of the geom package #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-13790
branch
2 times, most recently
from
07150ce
to
588b656
Compare
Use lsst.sphgeom.ConvexPolygon.convexHull instead of lsst.geom.convexHull
PaulPrice
approved these changes
May 10, 2018
| skyMapConfig.raList.append(circleCenter[0].asDegrees()) | ||
| skyMapConfig.decList.append(circleCenter[1].asDegrees()) | ||
| circleRadiusDeg = circle.getOpeningAngle().asDegrees() | ||
| skyMapConfig.radiusList.append(circleRadiusDeg + self.config.borderSize) |
There was a problem hiding this comment.
What's wrong with circle.radius?
There was a problem hiding this comment.
lsst.sphgeom.Circle does not support radius or getRadius; the equivalent method is getOpeningAngle(). Unfortunately the sphgeom pybind11 wrapper doesn't seem to use properties, as openingAngle would be nicer than getOpeningAngle(). We make small enough use of sphgeom that I figured we could live with that, but I am not happy about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.