Tickets/DM-2915: Port safe coadd clipping from HSC #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -130,6 +133,7 @@ def __init__(self, *args, **kwargs): | |||
| self.makeSubtask("interpImage") | |||
| self.makeSubtask("matchBackgrounds") | |||
| self.makeSubtask("scaleZeroPoint") | |||
| self.testvar = 10 | |||
natelust
force-pushed
the
tickets/DM-2915
branch
2 times, most recently
from
72fe8f1
to
2105159
Compare
|
A couple of generic comments on the commit messages:
|
| @@ -20,7 +20,34 @@ | |||
| # the GNU General Public License along with this program. If not, | |||
| # see <http://www.lsstcorp.org/LegalNotices/>. | |||
| # | |||
| from __future__ import print_function | |||
| import lsst.pex.logging as pexLog | |||
There was a problem hiding this comment.
pexLog is unused. You're not changing that line here, but maybe take this opportunity to remove it?
| @@ -478,6 +478,9 @@ class MeasureMergedCoaddSourcesConfig(Config): | |||
| def setDefaults(self): | |||
| Config.setDefaults(self) | |||
| self.deblend.propagateAllPeaks = True | |||
| # The following line must be set if clipped pixel flags are to be added to the output table | |||
| # The clipped mask plane is added by running the clipped coadd task | |||
There was a problem hiding this comment.
Please give the specific name of "the clipped coadd task".
Identify objects in the tempExp files that need to be clipped by looking at the difference between a clipped and unclipped coadd. The clipped masks that get created for each tempExp are not currently stored. PORT: This code has moved locations from HscPipe to pipe_tasks in LSST. Original commit can be found at https://hsc-jira.astro.princeton.edu/jira/browse/HSC-1166
Safe coadd clipping introduces a new mask plane, "CLIPPED". In order for routines to see this plan and add appropriate pixel flags, we must specify it as a plane to read. The configuration for pixelFlags algorithm has an any and center plane, which specifies if the routine should look for the plane anywhere in the foot print or near the center and set the flag accordingly.
Changed the "binary" command used to run assemble coadd. By default the command will run the new SafeClipAssembleCoaddTask. If the --legacyCoadd option is passed with the command, it will run the original coadd task, and print a message warning the user to set configuration changes necessary so future tasks run with a coadd made with the legacy code will not fail. In the case where no arguments are passed, the default help message will be triggered in the task argument parser. To ensure the extra help is printed, the function needs to print its help when the argument list has zero length.
natelust
force-pushed
the
tickets/DM-2915
branch
from
3b346b7
to
a38fce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.