Tickets/DM-14553: Extend multiBand.py to work with dcrCoadds.
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-14553
branch
from
2ca7b09
to
acf0dad
Compare
isullivan
force-pushed
the
tickets/DM-14553
branch
from
acf0dad
to
5fff057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
multiBand.pyto detect, measure, and merge sources on dcrCoadds.Note that the two commits in this pull request each represent a different way to accomplish this, and only one of them will be used.
In the first commit, I simply sub-class each of the necessary Tasks and update a couple methods with new (hard-coded) values.
In the second commit, I instead replace the existing hard-coded values with dynamic datasetTypes, with defaults that preserve backwards compatibility. This looks neater, but it requires the user to know to specify
--id_dstype=dcrCoadd,--id_dstype=dcrCoadd_det,--id_dstype=dcrCoadd_calexp, or--id_dstype=dcrCoadd_meason the command line depending on which Task is being run.If the latter approach is strongly preferred, I would appreciate advice on crafting help and error messages that will clue the user in to the correct command-line argument.