DM-10302 Change flux->instFlux #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-10302
branch
from
f31ac9d
to
6a68d21
Compare
r-owen
approved these changes
Sep 14, 2018
examples/photoCalTask.py
Outdated
| @@ -102,7 +102,7 @@ def run(): | |||
| print("Adding columns to the source catalogue") | |||
| cat = afwTable.SourceCatalog(schema) | |||
| cat.table.defineCentroid(srcCat.table.getCentroidDefinition()) | |||
| cat.table.definePsfFlux(srcCat.table.getPsfFluxDefinition()) | |||
| cat.table.definePsfFlux(srcCat.table.schema.getAliasMap().get("slot_psfFlux")) | |||
There was a problem hiding this comment.
Are you sure this will be in the alias map? Did you try using schema.get("slot_psfFlux")?
There was a problem hiding this comment.
I'd been working off the recommendation from the original deprecation warning, but yours is better, I think.
parejkoj
force-pushed
the
tickets/DM-10302
branch
2 times, most recently
from
5d00bf5
to
7c3930e
Compare
parejkoj
force-pushed
the
tickets/DM-10302
branch
2 times, most recently
from
3126c65
to
b88532b
Compare
parejkoj
force-pushed
the
tickets/DM-10302
branch
from
b88532b
to
61ef4d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.