DM-16082: Fix compression-option warnings in coadds test. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-16082
branch
from
726c792
to
8c51ce4
Compare
parejkoj
approved these changes
Nov 17, 2018
| @@ -95,6 +95,28 @@ def makeButlerLocation(cls, path, dataId, mapper, suffix=None, storage=None): | |||
| if suffix is None: | |||
| loc = super(ExposurePersistenceType, cls).makeButlerLocation(path, dataId, mapper, suffix=None, | |||
| storage=storage) | |||
| # Write options are never applicable for _sub, since that's only | |||
| # for read None of the values aside from the "NONE"s matter, but | |||
There was a problem hiding this comment.
Is there missing punctuation between read and None here?
| # for read None of the values aside from the "NONE"s matter, but | ||
| # writing explicit meaningless values for all of them to appease | ||
| # afw is the price we pay for trying to write a non-CameraMapper | ||
| # Mapper. It'll all bet better with Gen3 (TM). |
There was a problem hiding this comment.
Is this worth a TODO: with a ticket number to remind us to clean it up after Gen3?
There was a problem hiding this comment.
I don't think so; the whole concept of a mapper will be going away, so I don't think there's any way we could end up with the same problem there.
TallJimbo
force-pushed
the
tickets/DM-16082
branch
from
8c51ce4
to
a344fe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.