DM-16731: Fix DcrCoadd missing mask planes #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-16731
branch
from
520b7d5
to
73c39f7
Compare
isullivan
force-pushed
the
tickets/DM-16731
branch
from
73c39f7
to
d546943
Compare
mrawls
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mask planes were being cleared in the call to
findArtifacts, and inCompareWarpAssembleCoaddthey would get added back in during stacking. InDcrAssembleCoadd, however, we want to use the full mask plane from the initial non-DCR coadd throughout, because the masked regions would otherwise grow with every iteration. The simple solution implemented here is to copy the mask plane of the initial coadd beforefindArtifactsis run, and use that as the mask.Also, the initial coadd is now set to use
CompareWarpAssembleCoadd.