Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-13054: Refactor colorterm calculations to use in jointcal #266

Merged
merged 2 commits into from
Feb 9, 2019
Merged

DM-13054: Refactor colorterm calculations to use in jointcal #266

merged 2 commits into from
Feb 9, 2019

Commits on Feb 8, 2019

  1. Refactor colorterm calculations 

    The existing code made it very painful to compute the colorterm corrections.
Now `Colorterm.getCorrectedMagnitudes()` does all the necessary work.

I am skeptical of the magnitude error calculations here, but I'm just copying
them from PhotoCalTask, so they're at least not any more wrong than before.

This change does fix a serious bug in the refMagErr calculation: it was
previously being done using the secondary flux, not the primary flux (the loop
was overwriting `refFluxArr` before it was used to calculate the refMagErr).
    @parejkoj
    parejkoj committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    649a47a View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary print statement

    @parejkoj
    parejkoj committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    c54f7bb View commit details
    Browse the repository at this point in the history