DM-3373 Port HSC code for generation of calibration products #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def addRow(self, conn, info, *args, **kwargs): | ||
| """Add a row to the file table""" | ||
| info[self.config.validStart] = None | ||
| info[self.config.validEnd] = None |
There was a problem hiding this comment.
These seem to prompt additional changes for obs_decam. See comments in Jira.
PaulPrice
force-pushed
the
tickets/DM-3373
branch
2 times, most recently
from
f623188
to
f3a7ed3
Compare
We aim to have the calib registry end up in the calib root directory. To this end, we modify RegisterTask.openRegistry to take a directory instead of the butler (the butler was only being used to determine the directory). Our only access to the calib root directory is through the "--calib" command-line argument; if that is not provided, write to the current working directory for the user to move into the correct place.
Several assumptions within ingestCalibs were specific to obs_decam (esp. the use of the hard-coded "ccdnum" data identifier keyword). Made these assumptions configurable. This also involved updating the validity range calculations, which have been moved to a common place (fixSubsetValidity) instead of being in two places (IngestCalibsTask.run and fixSubsetValidity) and requiring users to set validStart and validEnd to dummy values. In the process, updated SQL to use placeholders instead of stringified values to proactively prevent escaping problems (similar to SQL injection).
PaulPrice
force-pushed
the
tickets/DM-3373
branch
from
f3a7ed3
to
7bc9153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.