Tickets/DM-18742: speed up DcrModel convergence #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-18742
branch
from
f59c824
to
78d5b24
Compare
kfindeisen
approved these changes
May 1, 2019
| @@ -112,7 +112,7 @@ class DcrAssembleCoaddConfig(CompareWarpAssembleCoaddConfig): | |||
| dtype=float, | |||
| doc="Maximum relative change of the model allowed between subfilters." | |||
| "Set to zero to disable.", | |||
| default=4., | |||
| default=10., | |||
There was a problem hiding this comment.
Is this to compensate for the rescaling? It seems a bit arbitrary.
There was a problem hiding this comment.
No, it's unrelated. I found the results improved very slightly with this change while I was testing frequency regularization. I can revert it if you think that would be cleaner.
| for model in dcrModels: | ||
| model.array = (model.array - refModel)*self.config.accelerateModel + refModel |
There was a problem hiding this comment.
Should this be conditional on accelerateModel > 1, like the similar code in buildMatchedTemplate?
isullivan
force-pushed
the
tickets/DM-18742
branch
from
78d5b24
to
8aa85ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option that amplifies the differences between DCR model planes to accelerate convergence. With default settings this is only applied within the footprints of detected sources, and only during the iterative forward modeling step of constructing the DcrModel.