DM-20472: measureCoaddSources: fix error from empty matches #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
force-pushed
the
tickets/DM-20472
branch
from
29ad467
to
9a45846
Compare
We can't generate a proper denormalised match list from no matches, because we don't have the schemas (which come from the matches); so lsst.meas.astrom.denormalizeMatches raises RuntimeError if there are no matches. We need to catch this case before calling denormalizeMatches. We generate a dummy denormalized matches file to keep the Gen3 butler happy (it's expecting an output of some kind).
PaulPrice
force-pushed
the
tickets/DM-20472
branch
from
9a45846
to
b8b8738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't generate a denormalised match list from no matches,
because we don't have the schemas (which come from the matches);
so lsst.meas.astrom.denormalizeMatches raises RuntimeError if
there are no matches. We need to catch this case before calling
denormalizeMatches.