Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-20566: Replace afwGeom with geom where appropriate #303

Merged
merged 1 commit into from Jul 18, 2019
Merged

DM-20566: Replace afwGeom with geom where appropriate #303

merged 1 commit into from Jul 18, 2019

Conversation

timj
Copy link
Member

@timj timj commented Jul 18, 2019

No description provided.

@timj timj requested a review from isullivan July 18, 2019 20:29
isullivan
isullivan approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward. makeSimpleCamera in simpleMapper.py must not have been used or tested anywhere. It would probably be good to have unit tests of the different mocks, even simple ones that just check that they run. We should file a new ticket for that.

@timj timj merged commit 24ce6f0 into master Jul 18, 2019
@timj timj deleted the tickets/DM-20566-pipe_tasks branch July 18, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @isullivan