DM-4692: Refactor ProcessCcdTask and sub-tasks #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Third commit ("Refactor ProcessCcdTask and sub-tasks") is far too large (1600+ lines added). Each of the bullet items should be a separate commit as far as possible. |
|
All commit messages should be in the imperative (e.g,. not "removed", but "remove"). |
| from lsst.pipe.tasks.calibrate import CalibrateTask | ||
|
|
||
| np.random.seed(1) | ||
|
|
||
| FilterName = "r" |
There was a problem hiding this comment.
Shouldn't have a leading capital, which is reserved for class names.
r-owen
force-pushed
the
tickets/DM-4692
branch
12 times, most recently
from
16ea159
to
65bd475
Compare
| @@ -0,0 +1,493 @@ | |||
| # | |||
| # LSST Data Management System | |||
| # Copyright 2008-2015 AURA/LSST. | |||
| # | ||
| # You should have received a copy of the LSST License Statement and | ||
| # the GNU General Public License along with this program. If not, | ||
| # see <http://www.lsstcorp.org/LegalNotices/>. |
There was a problem hiding this comment.
Modern version of this notice uses https://...
r-owen
force-pushed
the
tickets/DM-4692
branch
2 times, most recently
from
8ad73b9
to
ede56a4
Compare
This makes it easier to instantiate in unit tests.
r-owen
force-pushed
the
tickets/DM-4692
branch
2 times, most recently
from
ffc2ee9
to
84f6c0a
Compare
Document values returned by the "run" and "getZeroPoint" methods of PhotoCalTask. The information was incomplete for "run" and missing for "getZeroPoint".
As per RFC-136: ProcessCoaddTask is an outdated technique for measuring sources on coadds. The preferred technique is multi-band processing. The continued existence of ProcessCoaddTask is confusing.
Add a new task DetectAndMeasureTask to encapsulate the common sequence: detect and deblend sources and perform single-frame meas.
Add new command-line task CharacterizeImageTask to measure background, measure PSF and aperture correction, repair cosmic rays, and compute the icSrc catalog
Change default star selector in MeasurePsfTask from "secondMoment" to "objectSize" because the latter works better.
Expand documentation for MeasurePsfConfig.reserveFraction Remove obsolete "to do" warning message
Rewrite CalibrateTask as a command-line task whose run method performs persistence and calls the calibrate method to do the work. Rewrite ProcessCcdTask to call CharacterizeImageTask and the rewritten CalibrateTask, and inherit from CmdLineTask, not ProcessImageTask. Move InitialPsfConfig from ProcessImageTask to SnapCombineTask so that no code uses ProcessImageTask. Delete ProcessImageTask. Update TransformMeasurementTask, tests/testTransfor.py, and examples/calibrateTask.py for changes to CalibrateTask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.