DM-17023: update to new daf_butler APIs. #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-17023
branch
from
d3b00fb
to
8c708c4
Compare
andy-slac
approved these changes
Sep 19, 2019
python/lsst/pipe/tasks/calibrate.py
Outdated
| except AttributeError: | ||
| # Retargeting can mean that astromRefObjLoader doesn't have a | ||
| # ref_dataset_name, which is fine. | ||
| pass |
There was a problem hiding this comment.
This could quietly hide other errors than one described in comment, e.g. misspelled attribute name. It may be safer to do getattr(self.astromRefObjLoader, "ref_dataset_name", None) instead of catching an error. Same for try ... except below.
TallJimbo
force-pushed
the
tickets/DM-17023
branch
3 times, most recently
from
fc69a91
to
9acbe2f
Compare
We now rely on database constraints and insert optimistically, reraising with a better error message. This is better for concurrency and avoids reliance on direct SQL queries.
We're changing how we specify reference catalog names in configuration in the transition from Gen2 to Gen3, and in the interim it seems prudent to require that both [sets of] config options remain consistent. This of course will do nothing until we actually start calling config.validate() in the Gen3 executors, but that's a separate problem.
TallJimbo
force-pushed
the
tickets/DM-17023
branch
from
9acbe2f
to
ac698e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.