DM-20039: add fakeSources from a generator #326
Conversation
sr525
force-pushed
the
tickets/DM-20039
branch
from
50e9f13
to
a239e99
Compare
There was a problem hiding this comment.
You also need to change the documentation in addFakeSources method. maybe its best to do
...
fakeImages: typing.Iterator [tuple [lsst.afw.image.Image, lsst.geom.Point2D]]
Additionally John left some comments on Jira that should be looked at. Grab me if you need git help splitting up the commits.
arunkannawadi
force-pushed
the
tickets/DM-20039
branch
from
a239e99
to
8710d14
Compare
sr525
force-pushed
the
tickets/DM-20039
branch
from
8710d14
to
e921c6f
Compare
arunkannawadi
force-pushed
the
tickets/DM-20039
branch
2 times, most recently
from
857d3f2
to
05bfd66
Compare
arunkannawadi
changed the title
| @@ -373,6 +374,7 @@ def trim(row): | |||
|
|
|||
| return fakeCat[fakeCat.apply(trim, axis=1)] | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I think this new blank line should not be here
| @@ -531,8 +522,8 @@ def addFakeSources(self, image, fakeImages, sourceType): | |||
| ---------- | |||
| image : `lsst.afw.image.exposure.exposure.ExposureF` | |||
| The image into which the fake sources should be added | |||
| fakeImages : `list` | |||
| A list of tuples of `lsst.afw.image.ImageF` and `lsst.geom.Point2D, | |||
| fakeImages : `typing.Iterator` | |||
There was a problem hiding this comment.
After verifying with jonathan I think this should read
fakeImages : typing.Iterator [tuple ['lsst.afw.image.ImageF, lsst.geom.Point2d`]]
with the description line telling you what the image and point should be. i.e. "An iterator of tuples that contain images of fake sources, and the point at which they are to be inserted"
arunkannawadi
force-pushed
the
tickets/DM-20039
branch
from
05bfd66
to
feba102
Compare
arunkannawadi
force-pushed
the
tickets/DM-20039
branch
from
feba102
to
afc6bed
Compare
arunkannawadi
force-pushed
the
tickets/DM-20039
branch
from
afc6bed
to
7852719
Compare
No description provided.