DM-22505 Create run method in ImageDifferenceTask and move all functionality from runDataRef except butler usage #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2019 22:16
… in preparation for Gen3 suppport.
isullivan
requested changes
Dec 18, 2019
There was a problem hiding this comment.
This looks like a good start, though I think you don't need to move quite as much code into runDataRef. I had a few other suggestions for moving code blocks out of run and into new methods, but that might be beyond the scope of this ticket. I don't think it would be much work, but I will leave it up to you whether to include that now or later.
added 2 commits
December 25, 2019 21:46
Minor fix of variable initialization when zogy is run. Move loadAndMatch external catalog loading back into run(), should be gen3 compatible. Create makeIdFactory(). Add todo comments of DM-22762.
kgabor
force-pushed
the
tickets/DM-22505
branch
from
ca46f46
to
cc37a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.