Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-22541 Add initial gen3 support to ImageDifferenceTask. #333

Merged
merged 1 commit into from Mar 20, 2020
Merged

DM-22541 Add initial gen3 support to ImageDifferenceTask. #333

merged 1 commit into from Mar 20, 2020

Conversation

kgabor
Copy link
Member

@kgabor kgabor commented Jan 9, 2020

  • Add connection and minimal definition of inputs and outputs.
  • Add skymap as a task dimension, we do not support multiple skymaps in one run.

@kgabor kgabor changed the title Add initial gen3 support to ImageDifferenceTask. DM-22541 Add initial gen3 support to ImageDifferenceTask. Jan 9, 2020
isullivan
isullivan reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a very good start, though there are a few things that should be fixed before it is merged.

python/lsst/pipe/tasks/imageDifference.py Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Outdated Show resolved Hide resolved
@kgabor kgabor force-pushed the tickets/DM-22541 branch 4 times, most recently from d94f811 to fe2a3d7 Compare January 31, 2020 23:46
isullivan
isullivan approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are a few changes needed to go along with the changes I've requested on the PR in ip_diffim

python/lsst/pipe/tasks/imageDifference.py Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/imageDifference.py Show resolved Hide resolved
Add initial gen3 support to ImageDifferenceTask.
b5fed15 
 * Add connection and minimal definition of inputs and outputs.
 * Add skymap as a task dimension, we do not support multiple skymaps in one run.
 * Log message updates.
 * Data type template variable updates for more consistency.
 * Harmonisation of getTemplate method names runQuantum(), runDataRef(). Add missing data product dimensions.
@kgabor kgabor merged commit 735611d into master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kgabor @isullivan