DM-23342: Fix ingestDriver #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
Feb 6, 2020
python/lsst/pipe/tasks/ingest.py
Outdated
| self.register.addRow(registry, info, dryrun=args.dryrun, create=args.create) | ||
| except Exception as exc: | ||
| raise IngestError(f"Failed to register file {infile}", infile, pos) from exc | ||
| return hduInfoList |
There was a problem hiding this comment.
I would recommend only returning this if registry is None and otherwise returning None if everything has been registered.
This allows ingestion to be done later, as is required by ingestDriver.
This should make re-ingesting data less painful.
PaulPrice
force-pushed
the
tickets/DM-23342
branch
from
2029b99
to
7d27e3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.