DM-23104: Enable per-band flags in transform object #351
Conversation
yalsayyad
changed the title
python/lsst/pipe/tasks/functors.py
Outdated
| _radians = True | ||
| _defaultNoDup = True | ||
| _defaultNoDup = False |
There was a problem hiding this comment.
What's the reason for this change in the default behavior?
There was a problem hiding this comment.
👍 I tried to explain in the commit message, but it could use clarifying. Lots of words here:
We have a CoordColumn which is more specific than Column (it can convert radians to deg) and RA|DecColumn which is a special case of CoordColumn that looks for columns coord_ra and coord_dec. Before this ticket, CoordColumn doesn't explode out per band. Why not? I didn't want to write separate non-expanding CoordColumn because we can have those already with RAColumn and DecColumn. The alternative, (exploding) Column <-- ExplodingCoordColumn <-- (non-exploding) CoordColumn <-- (non-exploding)[RA|Dec]Column for functors that are all very slight variations of each other seems like overkill vs. (exploding) Column <-- (exploding) CoordColumn <-- (non-exploding)[RA|Dec]Column which is what this PR proposes. I think the only person who would notice is @timothydmorton
yalsayyad
force-pushed
the
tickets/DM-23104
branch
from
546b009
to
4462add
Compare
by splitting the `flags` key into two: * `flags` which will expanded out per band from meas * `refFlags` will be taked from ref
yalsayyad
force-pushed
the
tickets/DM-23104
branch
from
4462add
to
d302b3b
Compare
by behaving like other Columns which explode per band by default. RAColumn and DecColumn are now the non-exploding special cases that still produce a single reference band column. Change the behavior of intermediate CoordColumn preferred over adding a second intermediate class in the class hierarchy.
yalsayyad
force-pushed
the
tickets/DM-23104
branch
from
d302b3b
to
3e2e8b6
Compare
No description provided.