Review of DM-2754: Documentation for multiband coadd processing. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| We get the same deblending in all the bands. This allows us to run forced photometry on consistently deblended | ||
| objects which gives us reasonable colors. It also permits us to obtain measurements of flux in the case of | ||
| drop-out objects such as Lyman-break galaxies. Our strategy for meeting the consistent deblending requirement | ||
| can be broken up into a number of simple steps. |
There was a problem hiding this comment.
This introductory paragraph could usefully be extended a bit by incorporating some of the material from the HSC equivalent. In particular, the HSC paragraphs labelled "forced photometry" and "model magnitude issue" go into a (little!) bit more detail than you've done, and I think you should capture that.
There was a problem hiding this comment.
(Fixed link above to point to public version of the documentation.)
|
Please reformat the commit message to comply with the usual standards (max 50 characters in the imperative, blank line, full description). |
AstroVPK
force-pushed
the
tickets/DM-2754
branch
2 times, most recently
from
91c273c
to
2737aa4
Compare
jdswinbank
force-pushed
the
tickets/DM-2754
branch
2 times, most recently
from
c523fce
to
188765d
Compare
Add documentation to multiBand.py and a high-level overview of multi-band coadd processing.
jdswinbank
force-pushed
the
tickets/DM-2754
branch
from
188765d
to
ee03b53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.