DM-24290: Remove if Butler exists checks from bin.src scripts. #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
from
5d0afca
to
00e071b
Compare
|
@TallJimbo maybe you could share your thoughts on this PR when you find the time? |
TallJimbo
approved these changes
Apr 15, 2020
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
from
00e071b
to
ee71749
Compare
Checks are made against local filesystem only. This stopped being a valid assumption since S3Datastore was implemented as the data repository does not need to be local anymore. The failure case should be handled internaly by Butler itself at instantiation time.
DinoBektesevic
force-pushed
the
tickets/DM-24290
branch
from
ee71749
to
4f2177c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks are made against local filesystem only. This stopped being a valid assumption since S3Datastore was implemented as the data repository does not need to be local anymore.
The failure case should be handled internally by Butler itself at instantiation time.
These check currently block executing
makeGen3SkyMapif the location of the data repository is in S3 (f.e.s3://bucketname/).The errors raised by the butler are either
RuntimeErrorif the butler config file is of unknown format orFileNotFoundErrorif it's not at the given location. I think this is fine, but if required I think it should be possible to reinstate the exact error messages as before by attempting to instantiate a Butler, catching the exceptions and then printing and exiting with error code 1.