DM-17538: Generate stack-produced (rather than CP) calibration products for DECam #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
force-pushed
the
tickets/DM-17538
branch
3 times, most recently
from
699150a
to
f85ff00
Compare
parejkoj
approved these changes
Jul 2, 2020
getExtension is only ever invoked for multi-extension FITS files, and in practice that means DECam. The method was not behaving as advertised and was needlessly overridden in obs_decam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getExtension method during ingestion is only used for multi-extension FITS files, and in practice that means DECam. The method was not behaving as advertised and was overridden in both ingest and ingestCalibs in obs_decam. Those overrides have been removed and the method here in pipe_tasks now works as intended.