Review for DM-4831: Add bright object masks to pipeline outputs #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def setDefaults(self): | ||
| CoaddBaseTask.ConfigClass.setDefaults(self) | ||
| self.badMaskPlanes = ["NO_DATA", "BAD", "CR",] | ||
|
|
||
|
|
There was a problem hiding this comment.
The whitespace churn is gratuitous (& I'm not even sure it's an improvement).
natelust
force-pushed
the
tickets/DM-4831
branch
2 times, most recently
from
a107a86
to
eb186c5
Compare
pipe_tasks (HSC-1342) uses the butler to read these files, of type "brightObjectMask" to set a bit mask and flags for bright objects.
assembleCoadd.py reads an externally provided specification of bright object masks (via the butler type "brightObjectMask" which is added in obs_subaru on this ticket) and sets a mask plane in the exposure, by default BRIGHT_OBJECT. This is intended to allow us to mask bright stars and other troublesome objects for LSS and other studies. obs/subaru/config/assembleCoadd.py sets flag bits in sources that fall within this mask.
The 'run' method should be simple so that it may be simply replicated by subclasses. Moved the relatively lengthy read of the bright object masks into its own method. Might have moved it into the 'setBrightObjectMasks' method, but we want algorithmic code to be independent of I/O.
So we know it's being done.
natelust
force-pushed
the
tickets/DM-4831
branch
from
eb186c5
to
df27754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.