DM-25115 Implement zogy subtraction with non-spatial PSF #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Jun 18, 2020
| subtractedExposure = subtractRes.subtractedExposure | ||
| subtractRes = self.subtract.run(exposure, templateExposure, doWarping=True) | ||
| if self.config.doPreConvolve: | ||
| subtractedExposure = subtractRes.scoreExp |
There was a problem hiding this comment.
See my comments in ip_diffim about score vs scorr
| spatiallyVarying=self.config.doSpatiallyVarying, | ||
| doPreConvolve=self.config.doPreConvolve) | ||
| subtractedExposure = subtractRes.subtractedExposure | ||
| subtractRes = self.subtract.run(exposure, templateExposure, doWarping=True) |
There was a problem hiding this comment.
I would also supply the keyword calculateS=True in the call to run, though see my comment in ip_diffim about renaming that keyword.
kgabor
force-pushed
the
tickets/DM-25115
branch
2 times, most recently
from
fd0e425
to
54f119b
Compare
kgabor
force-pushed
the
tickets/DM-25115
branch
from
54f119b
to
5d34915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.