Add ability to add fake sources selectively to either the template or… #398
Conversation
| @@ -190,6 +190,14 @@ class InsertFakesConfig(PipelineTaskConfig, | |||
| default="deep", | |||
| ) | |||
|
|
|||
| template = pexConfig.Field( | |||
| doc="If the image is to be used as a template then set to True. This will add only sources with" | |||
There was a problem hiding this comment.
The doc description is a bit confusing and could use some simplifying. Especially the third sentence. As for a suggestion for the names "template" seems fine, but perhaps "image" could be changed to "visistExposure" or "ccdVisitExposure"?
There was a problem hiding this comment.
The columns themselves might need a bit more descriptive name like isTemplateSource or insertIntoTemplate. Might help with naming to think of them like this.
There was a problem hiding this comment.
In case anyone wants to put sources with different fluxes into different coadds, I changed the column names to 'isTemplateSource' and 'isNotOnlyTemplateSource'.
There was a problem hiding this comment.
I have tried to make this doc clearer and will add more details to the community post instructions when I update them. (Which I will do once we have finalised the discussion on this.)
| ----- | ||
| If the cofig option 'template' is set to True then only objects with the 'template' column | ||
| in the input fakes catalog will be added to the given image. If the 'image' column is set | ||
| to True then objects will only be added if the config option 'template' is set to False. If |
There was a problem hiding this comment.
Again, the notes here is a bit confusing and could use some edits.
| @@ -555,6 +570,22 @@ def cleanCat(self, fakeCat): | |||
| self.log.info("Removing %d rows with nBulge or nDisk outside of %0.2f <= n <= %0.2f" % | |||
| (badRows, minN, maxN)) | |||
|
|
|||
| if self.config.template: | |||
| try: | |||
| goodRows = (fakeCat["template"]) | |||
There was a problem hiding this comment.
goodRows and badRows is a bit unclear what you're actually doing here. I assume this is left over from another test but the rows for these settings aren't bad or good. They are just used or aren't.
There was a problem hiding this comment.
I've changed the names throughout this function as the point you make here is valid not just for this bit and I would like to keep the naming consistent.
|
|
||
|
|
||
| class MkTransientFakesCatalogTask(PipelineTask, CmdLineTask): | ||
| """Insert fake objects into calexps. |
There was a problem hiding this comment.
Is this doc copied from a previous task? Doesn't line up with the task name.
There was a problem hiding this comment.
mkTransientFakesCatalogTask was supposed to be deleted, I'm not sure why it wasn't deleted remotely.
| super().setDefaults() | ||
|
|
||
|
|
||
| class MkTransientFakesCatalogTask(PipelineTask, CmdLineTask): |
There was a problem hiding this comment.
Is this task name communicating what the task is doing? Looks to insert into an image and run calibrate to detect sources. The name currently reads like it's creating a catalog of fakes.
sr525
force-pushed
the
tickets/DM-25662
branch
4 times, most recently
from
a41b110
to
facb0c9
Compare
… the calexp.