DM-26011: Issue better error message if the detector name is not known to the camera #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
Jul 19, 2020
| # Give informative error message if the detector name is not known | ||
| # rather than a simple KeyError | ||
| if chip_name not in name_map: | ||
| detectors = [det for det in camera.getNameIter()] |
There was a problem hiding this comment.
Are you sure you want to do this for LSSTCam?
There was a problem hiding this comment.
I did try it out and it was only 3 lines on my terminal. I think I'll list the first 5 detectors as examples or something (I did it first because the name of the camera always say lsstCam in the obs_lsst camera YAML -- something which I later fixed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.