DM-26171: calibrations cannot be retrieved on the last day of a validity range #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -175,7 +175,7 @@ def fixSubsetValidity(self, conn, table, detectorData, validity): | |||
| if valids[date][1] > midpoint: | |||
| nextDate = dates[i + 1] | |||
| valids[nextDate][0] = midpoint + datetime.timedelta(1) | |||
| valids[date][1] = midpoint | |||
| valids[date][1] = midpoint + datetime.timedelta(1) | |||
There was a problem hiding this comment.
Did you find a way to confirm that this part of the fix is correct experimentally?
There was a problem hiding this comment.
My initial change removed the + datetime.timedelta(1) on line 177. However, this resulted in both validEnd_i and validStart_{i+1} being one day early. That was clearly wrong, as the calibDate was not contained within the range, leading to this version that increments both fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove single-day gaps in validation ranges.