DM-4210: Create documentation and examples for SafeClipAssembleCoadd #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
changed the title
| \copybrief AssembleCoaddTask_ | ||
|
|
||
| We want to assemble a coadded image from a set of coadded temporary exposures (coaddTempExps). We implicitly | ||
| assume that the coaddTempExps were all observed in the same filter band. Each input coaddTempExp |
There was a problem hiding this comment.
I think the code is generic enough that we do not assume that the coaddTempExps are from the same filter. I would remove this comment.
AstroVPK
force-pushed
the
tickets/DM-4210
branch
from
245eea2
to
92405ce
Compare
|
|
||
| For each coaddTempExp, check for (and swap in) an alternative mask if one is passed. If background | ||
| matching is enabled, add the background and background variance from each coaddTempExp. Remove mask | ||
| planes listed in config.removeMaskPlanes (default 'CROSSTALK', 'NOT_DEBLENDED'), Finally, mean-stack |
There was a problem hiding this comment.
I don't think you need to list the default mask planes to be removed.
AstroVPK
force-pushed
the
tickets/DM-4210
branch
from
92405ce
to
109c6cc
Compare
for assembleCoadd.py Example-based documentation has been added for the AssembleCoaddTask class, the SafeClipAssembleCoadd class and some utility functions in Cooaddbase.py
AstroVPK
force-pushed
the
tickets/DM-4210
branch
from
109c6cc
to
c4aefc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for assembleCoadd.py
Example-based documentation has been added for the
AssembleCoaddTask class, the SafeClipAssembleCoadd
class and some utility functions in Cooaddbase.py