DM-26586: Skip initial cosmic ray detection if it fails #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please control this behaviour with a configuration option set by the user, defaulting to False |
isullivan
force-pushed
the
tickets/DM-26586
branch
from
a8a9592
to
acc6864
Compare
ebellm
approved these changes
Sep 24, 2020
isullivan
force-pushed
the
tickets/DM-26586
branch
from
acc6864
to
8f1e1ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In very crowded fields, the cosmic ray detection algorithm can fail if it doesn't have a good PSF. We do an initial CR detection at the start of each iteration of measuring the PSF in image characterization, which means it uses the default PSF for the first iteration. By simply skipping CR masking if it fails at this stage we can get an improved PSF model, which can be used to perform CR masking in subsequent iterations.