DM-26613: Add make-discrete-skymap subcommand to butler #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
force-pushed
the
tickets/DM-26613
branch
2 times, most recently
from
d305eda
to
2775c45
Compare
n8pease
reviewed
Sep 28, 2020
timj
approved these changes
Sep 28, 2020
|
the CLI changes look good to me, as noted you should add the options_file_option |
timj
reviewed
Sep 28, 2020
SimonKrughoff
force-pushed
the
tickets/DM-26613
branch
from
388e888
to
d703151
Compare
This is specifically for a subcommand to make a discrete skymap from a set of calibrated exposures in an existing repository
The gen2 version should be reading the wcs from the repository not constructing it on the fly. This allows for removing the specialization for Gen3 since the metadata from Gen3 was does not contain enough information to construct a WCS.
SimonKrughoff
force-pushed
the
tickets/DM-26613
branch
from
d703151
to
3d0d138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides equivalent functionality to
makeDiscreteSkymap.pyin the gen2 system. It is implemented as a subcommand of thebutlercommand line tool.