DM-25990: Reprocess HSC COSMOS medium dataset with ap_pipe #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Oct 30, 2020
Comment on lines
331
to
332
| raise ValueError("If you are scaling the diffim variance, it is pointless to also " | ||
| "scale the template variance. Please choose one or the other.") |
There was a problem hiding this comment.
I would avoid error messages that judge the user. How about "Scaling the difference image variance and template variance are both set. Please choose one or the other."
| @@ -601,6 +608,7 @@ def run(self, exposure=None, selectSources=None, templateExposure=None, template | |||
|
|
|||
| if self.config.doSubtract: | |||
| if self.config.doScaleTemplateVariance: | |||
| self.log.info("Rescaling template variance") | |||
| templateVarFactor = self.scaleVariance.run( | |||
| templateExposure.getMaskedImage()) | |||
| self.metadata.add("scaleTemplateVarianceFactor", templateVarFactor) | |||
There was a problem hiding this comment.
Please add a log message stating the template variance scaling that is being used.
| self.log.info("Rescaling diffim variance") | ||
| diffimVarFactor = self.scaleVariance.run(subtractedExposure.getMaskedImage()) | ||
| self.metadata.add("scaleDiffimVarianceFactor", diffimVarFactor) | ||
|
|
There was a problem hiding this comment.
Please add a log message stating the difference image variance scaling that is being used.
mrawls
force-pushed
the
tickets/DM-25990
branch
2 times, most recently
from
b139e35
to
2bbea52
Compare
mrawls
force-pushed
the
tickets/DM-25990
branch
from
2bbea52
to
5325971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a doScaleDiffimVariance config option, which was set True for this ticket's ap_pipe rerun.