DM-5304: Use psfex as the default PSF determiner #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't want to refactor this test at all: it's a purely empirical test. I'm not a fan of how the test is implemented, but I'd much rather not dig into it here. |
parejkoj
force-pushed
the
tickets/DM-5304
branch
from
0688bdc
to
7f46e62
Compare
|
Sure, I didn't necessarily mean to refactor the test. It'd be helpful to write some instructions as to how you came up with those numbers. If I made an algorithmic change that makes this test fail, I wouldn't know how to find the new set of numbers. |
|
Okay, I see the comments now. |
arunkannawadi
approved these changes
Nov 2, 2020
Test values changed slightly, but they are purely empirical; add a note to the test to emphasize that for future developers.
parejkoj
force-pushed
the
tickets/DM-5304
branch
from
7f46e62
to
7797f63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.