DM-26615: remove afw filter wavelength dependence from DCR model #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-26615
branch
from
8ae0807
to
1f2db76
Compare
taranu
approved these changes
Nov 3, 2020
isullivan
force-pushed
the
tickets/DM-26615
branch
from
1f2db76
to
179d831
Compare
In order to replace the wavelength information that used to be retrieved from the filter, the effective wavelength and bandwidth must now be set in the config. The correct approach is to integrate over the actual transmission curve of the filter, which will be added in DM-13668.
isullivan
force-pushed
the
tickets/DM-26615
branch
from
179d831
to
40eb44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.