Allow a DeferredDatasetHandle to be passed to a Functor #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For gen3 compatibility, this allows for a DeferredDatasetHandle to be be passed to a functor's __call__ method, rather than the gen2 parquet interface ParquetTable object. All currently tested Functor functionality is also tested here for the gen3 model. Backward compatibility with gen2 is maintained. N.B.: the gen3 functor performance will likely be slower than the gen2 performance; remains to be seen if this matters at all.
In practical CompositeFunctor use cases (e.g. in ci_hsc), sometimes there are non-existent columns that are requested. This tests to make sure they execute without breaking.
The cases where the ParquetTable object has a _pf attribute already correctly drops non-existent columns and then requests only the cleaned column list; this corrects that for the case where _pf is none and _df is set.
timothydmorton
force-pushed
the
tickets/DM-27008
branch
from
6eb2b64
to
727ed2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For gen3 compatibility, this allows for a DeferredDatasetHandle to be be passed to a functor's call method, rather than the gen2 parquet interface ParquetTable object. All currently tested Functor functionality is also tested here for the gen3 model. Backward compatibility with gen2 is maintained. N.B.: the gen3 functor performance will likely be slower than the gen2 performance; remains to be seen if this matters at all.
Further note, this commit had previously broken ci_hsc because of one line where I had accidentally left a
raiseinstead of continuing on to use a.fail()method (had been in there for debugging purposes and removal should pass ci_hsc).