DM-28103: Revert changes to use subtasks from DM-24731 #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-28103
branch
from
2c18626
to
f0dacf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes from DM-24731 to
SafeClipAssembleCoaddTaskthat converted the computation ofcoaddMeanandcoaddClipto use subtasks. I had thought that it was necessary to use subtasks in order to run mock versions of the tasks in unit tests, but the tests currently pass with those changes reverted. Reverting the changes better ensures that thecoaddMeanandcoaddClipare computed using the correct config settings fromSafeClipAssembleCoaddTask