DM-27896: Add summary statistics component to Exposure #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
force-pushed
the
tickets/DM-27896
branch
2 times, most recently
from
5d6c7a4
to
1c67f3e
Compare
timj
approved these changes
Jan 28, 2021
| warnings.simplefilter('ignore') | ||
| altaz = coord.transform_to(AltAz) | ||
|
|
||
| zenithDistance = altaz.alt.degree |
There was a problem hiding this comment.
Given that this is already known to ObservationInfo (and possibly directly calculated from the FITS headers) it seems a bit wasteful to calculate it here from the ra/dec/time. Can we add zenith distance to visitInfo (like it is already in the butler exposure table)?
There was a problem hiding this comment.
So the fits header records boresight info, but we want this per-detector (which can vary significantly for the LSST FOV). So "visitInfo" isn't the right place because it's not per-visit information.
There was a problem hiding this comment.
Ah. Can you add a comment to that effect then?
erykoff
force-pushed
the
tickets/DM-27896
branch
from
3e8bcd4
to
bd2aacd
Compare
kfindeisen
approved these changes
Jan 28, 2021
erykoff
force-pushed
the
tickets/DM-27896
branch
from
bd2aacd
to
830141f
Compare
erykoff
force-pushed
the
tickets/DM-27896
branch
from
830141f
to
29cea05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.