DM-25894: Extract stars on, or slightly beyond, exposure edge #454
Conversation
MorganSchmitz
force-pushed
the
tickets/DM-25894
branch
3 times, most recently
from
19782b1
to
f1be38c
Compare
| @@ -127,6 +128,12 @@ class ProcessBrightStarsConfig(pipeBase.PipelineTaskConfig, | |||
| " annular flux.", | |||
| default=('BAD', 'CR', 'CROSSTALK', 'EDGE', 'NO_DATA', 'SAT', 'SUSPECT', 'UNMASKEDNAN') | |||
| ) | |||
| minPixelsWithinFrame = pexConfig.Field( | |||
| dtype=int, | |||
| doc="When a bright star is beyond exposure boundary, what is the minimal number of pixels that still " | |||
There was a problem hiding this comment.
I would suggest rewording to something like: The minimum number of pixels that must fall within the stamp boundary for the bright star to be saved when it is beyond the exposure boundary.
| @@ -207,8 +214,12 @@ def extractStamps(self, inputExposure, refObjLoader=None): | |||
| GMags = [] | |||
| ids = [] | |||
| wcs = inputExposure.getWcs() | |||
| # select stars within input exposure from refcat | |||
| withinCalexp = refObjLoader.loadPixelBox(inputExposure.getBBox(), wcs, filterName="phot_g_mean") | |||
| bmp = inputExposure.mask.getMaskPlaneDict() | |||
There was a problem hiding this comment.
I would prefer a more descriptive name than bmp.
| inputExpBBox = inputExposure.getBBox() | ||
| dilatationExtent = geom.Extent2I(np.array(self.config.stampSize) - self.config.minPixelsWithinFrame) | ||
| withinCalexp = refObjLoader.loadPixelBox(inputExpBBox.dilatedBy(dilatationExtent), wcs, | ||
| filterName="phot_g_mean") |
There was a problem hiding this comment.
Is the filter always going to be phot_g_mean?
There was a problem hiding this comment.
For now, yes. The refcat used will always be Gaia, and the band always (Gaia) G.
This will only change with DM-25175, and I was planning on adjusting this when we get there. I added a TODO comment referencing the tickets for now.
MorganSchmitz
force-pushed
the
tickets/DM-25894
branch
from
f1be38c
to
5893255
Compare
| bboxCorner = np.array(cpix) - np.array(self.config.stampSize)/2 | ||
| bboxCorner = geom.Point2I(bboxCorner) | ||
| # compute bbox as it would be otherwise | ||
| idealBBox = geom.Box2I(geom.Point2I(bboxCorner), geom.Extent2I(self.config.stampSize)) |
There was a problem hiding this comment.
You've already cast it as a Point2I
| ids.append(allIds[j]) | ||
| try: | ||
| starIm = inputExposure.getCutout(sp, geom.Extent2I(self.config.stampSize)) | ||
| except InvalidParameterError: |
There was a problem hiding this comment.
I have slacked you a suggestion for how to replace this section.
MorganSchmitz
force-pushed
the
tickets/DM-25894
branch
4 times, most recently
from
8a7cf7e
to
85a1bbe
Compare
|
Thanks a lot for your suggestion. I went with a mix between your version and mine, but it is a lot easier to read that way! |
MorganSchmitz
force-pushed
the
tickets/DM-25894
branch
from
85a1bbe
to
2b88453
Compare
| if not fs.contains(geom.Point2I(cpix)): | ||
| otherFootprints.append(fs) | ||
| nbMatchingFootprints = len(allFootprints) - len(otherFootprints) | ||
| if not nbMatchingFootprints == 1: |
There was a problem hiding this comment.
Is this the only criteria that can trigger this condition?
Jira ticket
Jenkins run #33446