DM-28570: Take both width and height for cutouts #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
force-pushed
the
tickets/DM-28570
branch
from
62d3bf8
to
d5dd861
Compare
r-owen
approved these changes
Feb 2, 2021
| @@ -104,10 +104,11 @@ def run(self, in_table, calexp): | |||
| pt = geom.SpherePoint(geom.Angle(ra, geom.degrees), | |||
| geom.Angle(dec, geom.degrees)) | |||
| pix = wcs.skyToPixel(pt) | |||
| size = rec['size'].value | |||
| width = rec['xspan'].value | |||
| height = rec['yspan'].value | |||
There was a problem hiding this comment.
Please consider using xspan and yspan for variable names, in order to make it more obvious where they come from.
I can see arguments both ways. If you prefer what you have then by all means keep it.
| @@ -45,7 +45,7 @@ class CalexpCutoutTaskConfig(pipeBase.PipelineTaskConfig, | |||
|
|
|||
| class CalexpCutoutTask(pipeBase.PipelineTask): | |||
| """Task for computing cutouts on a specific calexp given | |||
| positions and sizes of the stamps. | |||
| positions, widths, and heights of the stamps. | |||
There was a problem hiding this comment.
I strongly suggest adding the words xspan and yspan here, to make it clearer which table columns are needed. For example:
given position, xspan (width), and yspan (height).
SimonKrughoff
force-pushed
the
tickets/DM-28570
branch
2 times, most recently
from
85cb4bc
to
88d3832
Compare
SimonKrughoff
force-pushed
the
tickets/DM-28570
branch
from
88d3832
to
082d6b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.