DM-28922: Correct functor logic to work with single-level datarefs, and add tests #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothydmorton
changed the title
morriscb
approved these changes
Feb 24, 2021
Previous updates to Functor to allow for passing a DeferredDatasetHandle did not have appropriate logic to allow for the handle to point to a dataframe with only a single-level column index. This corrects that, and adds corresponding tests, which were also missing before (which is why this bug was not caught).
timothydmorton
force-pushed
the
tickets/DM-28922
branch
from
b8e4b60
to
85c0230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous updates to Functor to allow for passing a DeferredDatasetHandle did not have appropriate logic to allow for the handle to point to a dataframe with only a single-level column index. This corrects that, and adds corresponding tests, which were also missing before (which is why this bug was not caught).