DM-20695: Convert SelectImageTasks to Gen3 #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
approved these changes
Feb 26, 2021
| skyInfo=skyInfo) | ||
| if self.config.makeDirect: | ||
| butlerQC.put(results.exposures["direct"], outputRefs.direct) | ||
| if self.config.makePsfMatched: | ||
| butlerQC.put(results.exposures["psfMatched"], outputRefs.psfMatched) | ||
|
|
||
| def prepareCalibratedExposures(self, calExpList, backgroundList=None, skyCorrList=None): | ||
| def filterInputs(self, indices, inputs): | ||
| """Return task inputs with their lifsts filtered by indices |
There was a problem hiding this comment.
Suggested change
| """Return task inputs with their lifsts filtered by indices | |
| """Return task inputs with their lists filtered by indices |
* Refactor SelectImageTasks, adding a run method that takes lists of calexp properties. runDataRef remains the Gen2 entry point which still takes dataRefs. * MakeWarp now calls the configured selectImages subtask in runQuantum. The calexp list was changed to deferLoad, because the padding needed in the gen3 skymap is providing many more calexps than actually overlap the patch. Loading is performed after image selection is run, so that only the calexps that will be used are loaded into memory.
yalsayyad
force-pushed
the
tickets/DM-20695
branch
from
f42bfb3
to
adf4cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of calexp properties. runDataRef remains the Gen2 entry point
which still takes dataRefs.
runQuantum. The calexp list was changed to deferLoad, because the padding
needed in the gen3 skymap is providing many more calexps than actually
overlap the patch. Loading is performed after image selection is run,
so that only the calexps that will be used are loaded into memory.