DM-27613: Add gen3 ability to add external SkyWcs and PhotoCalib #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Mar 2, 2021
parejkoj
reviewed
Mar 2, 2021
fred3m
approved these changes
Mar 2, 2021
python/lsst/pipe/tasks/coaddBase.py
Outdated
| dtype=bool, | ||
| default=True, | ||
| doc=("When using doApplyExternalPhotoCalib, use global calibrations. " | ||
| "When False, per-tract calibrations will be used instead.") |
There was a problem hiding this comment.
Should the doc be a bit more explicit as to what is meant by global calibrations (FGCM for photometry and jointcal for astrometry), or will this be clear to people who need to worry about this?
erykoff
force-pushed
the
tickets/DM-27613
branch
from
b7b607a
to
5bd056a
Compare
erykoff
force-pushed
the
tickets/DM-27613
branch
from
5bd056a
to
5f2c73b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.