Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-27652: Write the QuickFrameMeasurementTask and unit tests. #476

Merged
merged 1 commit into from Mar 4, 2021

Conversation

mfisherlevine
Copy link
Contributor

This is an experimental task with a potentially volatile API
which should not yet be relied upon, i.e. its API is subject to
change without RFC as its primary purpose is in observing scripts
written by T&S.

The tasks goal is to, given a postISR image, quickly and robustly
find the centroid of the brightest star in the image.

Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the missing docstrings are the biggest issue. Subtasks for the other tasks called would probably make it simpler, and would push all the configuration parameters into the config class.

python/lsst/pipe/tasks/quickFrameMeasurement.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/quickFrameMeasurement.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/quickFrameMeasurement.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/quickFrameMeasurement.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/quickFrameMeasurement.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/quickFrameMeasurement.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/quickFrameMeasurement.py Outdated Show resolved Hide resolved
tests/test_quickFrameMeasurement.py Show resolved Hide resolved
@mfisherlevine mfisherlevine force-pushed the tickets/DM-27652 branch 4 times, most recently from f86a747 to 8c22b9c Compare March 3, 2021 23:07
This is an experimental task with a potentially volatile API
which should not yet be relied upon, i.e. its API is subject to
change without RFC as its primary purpose is in observing scripts
written by T&S.

The tasks goal is to, given a postISR image, quickly and robustly
find the centroid of the brightest star in the image.
@mfisherlevine mfisherlevine merged commit d3b4266 into master Mar 4, 2021
@mfisherlevine mfisherlevine deleted the tickets/DM-27652 branch March 4, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants