DM-29017: Update visitSummary catalogs to use detector id as index. #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Mar 3, 2021
| @@ -1041,7 +1043,7 @@ def _combineExposureMetadata(self, visit, dataRefs, isGen3=True): | |||
|
|
|||
| rec['physical_filter'] = filterLabel.physicalLabel if filterLabel.hasPhysicalLabel() else "" | |||
| rec['band'] = filterLabel.bandLabel if filterLabel.hasBandLabel() else "" | |||
| rec['detector_id'] = detector.getId() | |||
| rec['id'] = detector.getId() | |||
There was a problem hiding this comment.
I don't know that it makes any real difference, but you can also do rec.setId(detector.getId()) here, since every Catalog has id.
| @@ -1058,6 +1060,12 @@ def _combineExposureMetadata(self, visit, dataRefs, isGen3=True): | |||
| rec['raCorners'][:] = [sph.getRa().asDegrees() for sph in sph_pts] | |||
| rec['decCorners'][:] = [sph.getDec().asDegrees() for sph in sph_pts] | |||
|
|
|||
| metadata = dafBase.PropertyList() | |||
| metadata.add("COMMENT", "Catalog id is detector id, sorted.") | |||
| metadata.add("COMMENT", "Only detectors with data have entries.") | |||
There was a problem hiding this comment.
I guess this latter comment is true in this case because we're iterating over dataRefs. It wasn't entirely obvious to me at first.
erykoff
force-pushed
the
tickets/DM-29017
branch
from
5b01c43
to
60c1799
Compare
erykoff
force-pushed
the
tickets/DM-29017
branch
from
60c1799
to
990e6e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.