DM-29065: Sort all input lists by calexpList detector order in makeWarp #479
Conversation
| else: | ||
| inputKeyOrder = [ref.datasetRef.dataId[dataIdKey] for ref in refs] | ||
| if inputKeyOrder != outputKeyOrder: | ||
| setattr(inputRefs, key, reorderAndPadList(refs, inputKeyOrder, outputKeyOrder)) |
There was a problem hiding this comment.
Can this be inputRefs[key] = reorderAndPadList(refs, inputKeyOrder, outputKeyOrder)?
There was a problem hiding this comment.
Nope.
(Pdb) inputRefs[key]
*** TypeError: 'InputQuantizedConnection' object is not subscriptable
| for key, refs in inputRefs: | ||
| if isinstance(refs, Iterable): | ||
| if hasattr(refs[0], "dataId"): | ||
| inputKeyOrder = [ref.dataId[dataIdKey] for ref in refs] |
There was a problem hiding this comment.
This also applies to the function above which has just been moved and therefore might be outside the scope of this ticket. But the term key is used in two different ways here. One is a dict-like key (as in for key, refs in inputRefs) which is very pythonic. The other is a sorting key which I guess python sort functions also use the term key in this way, but in this particular method I find the overloading of the term confusing.
It may be verbose, but maybe call inputKeyOrder -> inputSortKeyOrder?
There was a problem hiding this comment.
The plain key --> connectionName,
inputKeyOrder --> inputSortKeyOrder,
outputKeyOrder --> outputSortKeyOrder
yalsayyad
force-pushed
the
tickets/DM-29065
branch
from
51388bc
to
70472ec
Compare
No description provided.