DM-28245: Update ConsolidateVisitSummaryTask to use calexp summaryStats. #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorganSchmitz
approved these changes
Apr 5, 2021
There was a problem hiding this comment.
LGTM! My only comment is not about the change itself, just nitpicking on a docstring clarification you made along the way.
It looks like we're adding a few new fields (zenithDistance etc) we got from the new summaryStatistics. Maybe it's worth mentioning this in the body of the commit message, just so we can easily pinpoint when that was done?
| @@ -1081,12 +1080,12 @@ def runQuantum(self, butlerQC, inputRefs, outputRefs): | |||
| butlerQC.put(expCatalog, outputRefs.visitSummary) | |||
|
|
|||
| def _combineExposureMetadata(self, visit, dataRefs, isGen3=True): | |||
| """Make a combined exposure catalog from a list of dataRefs. | |||
| """Make a combined exposure catalog from a list of calexp dataRefs. | |||
There was a problem hiding this comment.
I think I remember something about trying to avoid using the word "calexp" in user-facing places like docstrings, or did I make that up?
This commit adds additional fields available in the summaryStats, including detector center ra/decl; zenith distance; zero-point; and sky level and noise.
erykoff
force-pushed
the
tickets/DM-28245
branch
from
c044f6d
to
e971f76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.